Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo on the script installation file #1109

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix typo on the script installation file #1109

merged 1 commit into from
Mar 6, 2024

Conversation

mohammad-albarham
Copy link
Contributor

@mohammad-albarham mohammad-albarham commented Mar 6, 2024 •
edited
Loading

There is a a typo in this part of the installtion:

wget https://raw.githubusercontent.com/TimDettmers/bitsandbytes/main/install_cuda.sh
# Syntax cuda_install CUDA_VERSION INSTALL_PREFIX EXPORT_TO_BASH
#   CUDA_VERSION in {110, 111, 112, 113, 114, 115, 116, 117, 118, 120, 121, 122, 123}
#   EXPORT_TO_BASH in {0, 1} with 0=False and 1=True

# For example, the following installs CUDA 11.7 to ~/local/cuda-11.7 and exports the path to your .bashrc

bash cuda_install.sh 117 ~/local 1

we need to run the bash on the correct name as:

bash install_cuda.sh 117 ~/local 1

So, the instructions will be as:

wget https://raw.githubusercontent.com/TimDettmers/bitsandbytes/main/install_cuda.sh
# Syntax cuda_install CUDA_VERSION INSTALL_PREFIX EXPORT_TO_BASH
#   CUDA_VERSION in {110, 111, 112, 113, 114, 115, 116, 117, 118, 120, 121, 122, 123}
#   EXPORT_TO_BASH in {0, 1} with 0=False and 1=True

# For example, the following installs CUDA 11.7 to ~/local/cuda-11.7 and exports the path to your .bashrc

bash cuda_install.sh 117 ~/local 1

@Titus-von-Koeller
Copy link
Collaborator

Hey @mohammad-albarham!

Thanks a lot for the quick fix! Really appreciated. Yes, that script has been renamed recently and that mention of the script must have been overlooked at the time.

@Titus-von-Koeller Titus-von-Koeller merged commit 87e029b into bitsandbytes-foundation:main Mar 6, 2024
@mohammad-albarham mohammad-albarham deleted the fix_typo branch March 6, 2024 21:27
@akx
Copy link
Contributor

akx commented Mar 7, 2024

By the way @Titus-von-Koeller, I noticed you'd added a Python version of the script in e3b318b – do we want to maintain both .sh and .py...?

@Titus-von-Koeller
Copy link
Collaborator

@akx, I agree that we can delete the .sh, I kept it at the time because I wasn't sure how attached Tim was to it and I didn't have as much say as I have now, yet.

In my opinion it's best to remove. As a last quick check we'd have to take an extra careful look making sure that it really has feature-parity.

Feel free to do so, otherwise I'll also put in on my todo.

@Titus-von-Koeller Titus-von-Koeller mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammad-albarham @Titus-von-Koeller @akx